nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)
Apache License 2.0
402 stars 198 forks source link

Fix #2538, table transaction initial implementation #2539

Closed jphickey closed 3 months ago

jphickey commented 3 months ago

Checklist (Please check before submitting)

Describe the contribution Initial implementation of transaction concept for table API calls. The basic transaction object wraps all of the relevant pointers and state information for the request being processed.

Fixes #2538

Testing performed Build and run all tests

Expected behavior changes Internal code structure more manageable.
Behavior of external/public API calls should remain the same.

System(s) tested on Debian

Additional context Does not really "fix" the problem of race conditions alone, needs more work to actually move/reorg the problem areas. But this doesn't break anything that wasn't already broken (i.e. race conditions in here were there before). They are just more evident (and fixable) now.

Unit and functional tests (mostly) did not need to change for this, aside from a few minor details.

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.

jphickey commented 3 months ago

Still need to do some documentation updates on this PR. Will follow up with an update. Expecting the documentation-related workflow(s) to fail on this for now.

jphickey commented 3 months ago

Documentation updates should be resolved now, pending successful workflow run.