nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)
Apache License 2.0
402 stars 198 forks source link

Fix #2550, use resourceids for internal table validation and dump control blocks #2551

Closed jphickey closed 1 week ago

jphickey commented 2 months ago

Checklist (Please check before submitting)

Describe the contribution Use a resourceID value for access into the dump control and validation result structure arrays. This allows for consistent lookup, matching, and free/in-use determination, as well as improved resilience to race conditions and stale data.

Fixes #2550

Testing performed Build and run all tests, including functional and coverage. Sanity check all results.

Expected behavior changes No externally visible changes, but API calls and external commands may be more strict about commands they accept/reject due to extra validation checking.

System(s) tested on Debian

Additional context Registry records will also be converted to use similar patterns, as a separate commit/PR.

Contributor Info - All information REQUIRED for consideration of pull request Joseph Hickey, Vantage Systems, Inc.

dzbaker commented 2 months ago

CCB 25 April 2024: Will review next week when @jphickey is back.

dzbaker commented 2 months ago

CCB 2 May 2024: Approved pending BVT run.