[x] I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.
Describe the contribution
A clear and concise description of what the contribution is.
Include explicitly what issue it addresses [e.g. Fixes #X]
Fixes #2553, address issue that occur when running with address sanitizer. One of the coverage test was trying to pass an
null value to force an return code of 0 or less to an vsnprintf. Passing an null value as an input is an undefine behavior but you can achieve the same result by passing in an empty string which will force the return code to be 0.
Testing performed
Steps taken to test the contribution:
add the following options:
add_compile_options(-fsanitize=address -g)
add_link_options(-fsanitize=address)
make ENABLE_UNIT_TESTS=true SIMULATION=native prep
make install
make test
make lcov
Expected behavior changes
A clear and concise description of how this contribution will change behavior and level of impact.
no more error when running with fsanitize.
Still 100% coverage.
System(s) tested on
Hardware: [e.g. PC, SP0, MCP750]
OS: [e.g. Ubuntu 18.04, RTEMS 4.11, VxWorks 6.9]
Versions: [e.g. cFE 6.6, OSAL 4.2, PSP 1.3 for mcp750, any related apps or tools]
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)
Note CLAs apply to only software contributions.
Anh Van, GSFC
Fix #2553, fix test that was passing null value into vsnprintf
Checklist (Please check before submitting)
Describe the contribution A clear and concise description of what the contribution is.
Fixes #2553, address issue that occur when running with address sanitizer. One of the coverage test was trying to pass an null value to force an return code of 0 or less to an vsnprintf. Passing an null value as an input is an undefine behavior but you can achieve the same result by passing in an empty string which will force the return code to be 0.
Testing performed Steps taken to test the contribution: add the following options: add_compile_options(-fsanitize=address -g) add_link_options(-fsanitize=address)
Expected behavior changes A clear and concise description of how this contribution will change behavior and level of impact.
no more error when running with fsanitize. Still 100% coverage.
System(s) tested on
Additional context Add any other context about the contribution here.
Third party code If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request Full name and company/organization/center of all contributors ("Personal" if individual work)