nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)
Apache License 2.0
402 stars 198 forks source link

Fix #2556, flight like platformed defined values #2557

Open dmknutsen opened 2 months ago

dmknutsen commented 2 months ago

Checklist (Please check before submitting)

Describe the contribution Updates CFE_PLATFORM_EVS_LOG_MAX and CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC to align with 'flight like' values

Testing performed CI pipeline BVT testing

System(s) tested on

Contributor Info - All information REQUIRED for consideration of pull request Dan Knutsen NASA Goddard

skliper commented 2 months ago

Might be a surprise to anyone using the defaults? Is there a way to match the BVTs w/o open source behavior changes?

dmknutsen commented 2 months ago

Yep - we could just put the updates in the example_platform_cfg.h (and change the name as part of the test setup). I'm a bit surprised that the functional tests failed, as I just changed CFE_PLATFORM_EVS_APP_EVENTS_PER_SEC back to it's original value that I was thinking was more flight like. The only reason we changed it in the first place was to prevent test results from being squelched in the console output (cfe_test.log has always been correct). In any case, just using example_platform_cfg.h fixes both issues...I'll push an update.