nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)
Apache License 2.0
402 stars 198 forks source link

Fix #2559, Improve CFE_SB_AllocateMessageBuffer error report #2560

Closed skliper closed 1 week ago

skliper commented 2 months ago

Checklist (Please check before submitting)

Describe the contribution

Testing performed CI and ran in project context

Expected behavior changes Improved error message

System(s) tested on CI

Additional context None

Third party code None

Contributor Info - All information REQUIRED for consideration of pull request Jacob Hageman - NASA/GSFC

skliper commented 1 month ago

Seems good to me, fairly low impact/risk, and the nominal case is basically unchanged. Does raise a flag to me that we might need something like CFE_ES_WriteToSyslogWithAppID() or something like that, but we can save that for another day.

Love the idea, and function maybe via a macro? Standardization is awesome.

jphickey commented 1 month ago

Love the idea, and function maybe via a macro? Standardization is awesome.

Mainly because I was back into some TBL services code and this pattern appears a few times - to get the app name for the purpose of writing to syslog with an app context....