Fix #2529, Reduces CFE_EVS_MAX_PORT_MSG_LENGTH to prevent new line character truncation

[chillfig]

Checklist (Please check before submitting)

• [x] I reviewed the Contributing Guide.
• [x] I signed and emailed the appropriate Contributor License Agreement to GSFC-SoftwareRelease@mail.nasa.gov and copied cfs-program@lists.nasa.gov.

Describe the contribution A clear and concise description of what the contribution is.

• Fixes #2529, Adds snprintf check return value and buffer to PortMessage within EVS_SendViaPorts() to ensure enough space for format string characters in the downstream EVS_OutputPort() printing.

Testing performed Started cFS and reviewed startup messages.

Expected behavior changes Enough space should now be allocated to PortMessage such that it is null terminated and ends with a new line character when printed out via ports.

System(s) tested on

• OS: Ubuntu 22.04

Additional context Alternative solutions considered

• Enlarging CFE_EVS_MAX_PORT_MSG_LENGTH to allow for more space to PortMessage and therefore no unintended truncation
  • Thoughts: Trying not to use more resources if its not necessary
• Reducing the size of the messages passed in by CI_LAB_APP, CI_LAB_APP, and TO_LAB_APP (VS_PktPtr->Payload.Message) as these were the messages causing truncated strings on every cFS build and run.
  • Thoughts: Would work but wouldn't prevent future app message changes that are too long from truncating

cFS_startup_cpu1_PrePR.txt

This is what the startup messages look like after including this PR. cFS_startup_cpu1_19buf.txt

This is what the startup messages look like after including code to check for snprintf() return value. This Note that CI_LAB_APP, CI_LAB_APP, and TO_LAB_APP all now have Truncation warnings and the message isn't concatenated to the next discrete message but ends with a *\0 cFS_startup_cpu1_PostPR.txt

Third party code N/A

Contributor Info - All information REQUIRED for consideration of pull request Justin Figueroa, Vantage Systems

[chillfig]

CCB 5/30/2024: This is a configuration issue. Amend so that configuration parameters that work together and not add arbitrary limitations. Consider giving user control as to what CFE_EVS_MAX_PORT_MSG_LENGTH is. Consider that cfe_evs_task.h compile-time check for CFE_EVS_MAX_PORT_MSG_LENGTH looks at extra characters needed.

[chillfig]

Action: Write new low priority ticket for representing the 11 bytes reduced in CFE_EVS_MAX_PORT_MSG_LENGTH with this pull request

[chillfig]

Action: Write new low priority ticket for representing the 11 bytes reduced in CFE_EVS_MAX_PORT_MSG_LENGTH with this pull request

Done. https://github.com/nasa/cFE/issues/2571