search

nasa / cFE

The Core Flight System (cFS) Core Flight Executive (cFE)
Apache License 2.0
408 stars 200 forks source link

CFE ES makes assumptions about OSAL opaque objects #41

Closed skliper closed 4 years ago

skliper commented 4 years ago

OSAL returns object identifiers which are defined as uint32 values. In the current implementation of OSAL they happen to be zero-based but this should not be a requirement; in fact there are several advantages to making these identifiers non-zero-based.

The primary offender is the ES core application using the task ID from OSAL directly as an array index.

To ensure compatibility the OSAL object IDs should be treated as opaque integers of undefined range.

skliper commented 4 years ago

Imported from trac issue 10. Created by jphickey on 2014-12-30T20:56:40, last modified: 2019-03-05T14:57:55

skliper commented 4 years ago

Trac comment by glimes on 2015-02-11 11:51:49:

See [changeset:a220922]

skliper commented 4 years ago

Trac comment by jphickey on 2015-04-06 11:41:34:

This is ready for review/merge

Latest is [changeset:738fdbe]. (updated to address issue found after the fact)

skliper commented 4 years ago

Trac comment by acudmore on 2015-04-06 14:30:57:

recommend accept

Does this impact the ARINC653 OSAL implementation?

skliper commented 4 years ago

Trac comment by glimes on 2015-04-07 12:51:11:

Tested changeset [changeset:738fdbe] as part of the ic-2015-03-10 merge.

skliper commented 4 years ago

Trac comment by glimes on 2015-04-13 15:10:28:

Part of integration candidate 2015-03-10, committed to cFS CFE Development branch on 2015-04-10 as part of merge [changeset:7d6f6d0].

skliper commented 4 years ago

Trac comment by glimes on 2016-02-16 13:16:45:

Susie confirmed these tickets have been approved for CFE 6.5

skliper commented 4 years ago

Trac comment by jhageman on 2019-03-05 14:57:55:

Milestone renamed