nasa / cFS-GroundSystem

The Core Flight System (cFS) Ground System Lab Tool (cFS-GroundSystem)
Apache License 2.0
80 stars 62 forks source link

Telemetry GUI error - Individual telemetry pages do not open due to name errors in GenericTelemetry.py #202

Closed ghost closed 1 year ago

ghost commented 2 years ago

Describe the bug The Telemetry subsystem windows do not open anymore. When opening a telemetry window such as ES Housekeeping telemetry, it produces an error an error.

To Reproduce Steps to reproduce the behavior:

  1. Start GroundSystem.py
  2. In the cFS Ground System Main Window, hit the "Start Telemetry System" button.
  3. In the Telemetry System Page Window, hit the "Display Page" button next to ES HK Tlm

In the console you will see: NameError: name 'tlm_item_desc' is not defined.

I think the name convention change left a few old names in the file. From tlmItemDesc --> tlm_item_desc. See the Code snips section for all of the errors I found.

Expected behavior Telemetry window should open, displaying packet values in the window.

Code snips Look in cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py:

Line 71: tlmItemSize should be tlm_item_size Line 79: tlmItemEnum should be tlm_item_enum Line 82: tlmItemDesc should be tlm_item_desc Line 90: gtSignalTlmDatagram should be gt_signal_tlm_datagram

Line 220: tlmItemDesc should be tlm_item_desc Line 221: tlmItemSize should be tlm_item_size Line 222: tlmItemFormat should be tlm_item_format

System observed on:

Additional context N/A

Reporter Info Alan Cudmore NASA/GSFC