search

nasa / cFS-GroundSystem

The Core Flight System (cFS) Ground System Lab Tool (cFS-GroundSystem)
Apache License 2.0
80 stars 62 forks source link

Fix #202, naming error #217

Closed paulober closed 1 year ago

paulober commented 2 years ago

Sorry for that. Missed that one in conversion...

Describe the contribution

Contributor Info - All information REQUIRED for consideration of pull request Personal

skliper commented 2 years ago

On Ubuntu20.04 I still get:

Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 253, in <module>
    telem.init_gt_tlm_receiver(subscription)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 88, in init_gt_tlm_receiver
    self.thread.gtSignalTlmDatagram.connect(self.process_pending_datagrams)
AttributeError: 'GTTlmReceiver' object has no attribute 'gtSignalTlmDatagram'
paulober commented 2 years ago

On Ubuntu20.04 I still get:

Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 253, in <module>
    telem.init_gt_tlm_receiver(subscription)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 88, in init_gt_tlm_receiver
    self.thread.gtSignalTlmDatagram.connect(self.process_pending_datagrams)
AttributeError: 'GTTlmReceiver' object has no attribute 'gtSignalTlmDatagram'

Should be fixed now.

skliper commented 2 years ago

I still get the following errors (and the window doesn't open) when trying to open the ES HK Tlm page. Maybe I have a more fundamental issue?

Generic Telemetry Page started. Subscribed to GroundSystem.0x800
qt.qpa.xcb: X server does not support XInput 2
failed to get the current screen resources
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-jhageman'
qt.qpa.xcb: QXcbConnection: XCB error: 1 (BadRequest), sequence: 164, resource id: 90, major code: 130 (Unknown), minor code: 47
qt.qpa.xcb: QXcbConnection: XCB error: 170 (Unknown), sequence: 177, resource id: 90, major code: 146 (Unknown), minor code: 20
Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 110, in process_pending_datagrams
    self.display_telemetry_item(datagram, k, item_label, item_value)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 77, in display_telemetry_item
    value_field.setText(tlm_item_enum[tlm_index][int(tlm_field[0])])
IndexError: list index out of range
skliper commented 2 years ago

Adding CCB:Ignore label for now until issues are resolved.

paulober commented 2 years ago

I still get the following errors (and the window doesn't open) when trying to open the ES HK Tlm page. Maybe I have a more fundamental issue? [...]

Traceback (most recent call last):
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 110, in process_pending_datagrams
    self.display_telemetry_item(datagram, k, item_label, item_value)
  File "/home/jhageman/cFS/cFS-GitHub/tools/cFS-GroundSystem/Subsystems/tlmGUI/GenericTelemetry.py", line 77, in display_telemetry_item
    value_field.setText(tlm_item_enum[tlm_index][int(tlm_field[0])])
IndexError: list index out of range

🤔 strange, I just tested it on a new VM and it opens the window without any warnings or errors.

skliper commented 2 years ago

I'll try to take a closer look at it... just did a quick initial check.

skliper commented 1 year ago

OK, looks like this does fix #217. I was able to open both TBL and TIME HK pages. There's still an error with opening ES, I suspect the packet description is out of date. I'll open a new issue for that, but this change should be able to move forward.

chillfig commented 1 year ago

Approved. Just needs confirmation on contributor license agreement (cla). @paulober would you please confirm that you emailed in a cla?

paulober commented 1 year ago

Approved. Just needs confirmation on contributor license agreement (cla). @paulober would you please confirm that you emailed in a cla?

Confirm signed it allready.

skliper commented 1 year ago

@dzbaker @chillfig What's the status on this one? It's currently broken without it...

chillfig commented 1 year ago

@dzbaker @chillfig What's the status on this one? It's currently broken without it...

This pull request looks good to me to merge. @dzbaker is out of office until November 14. Can the merge wait until then?

dzbaker commented 1 year ago

@dzbaker @chillfig What's the status on this one? It's currently broken without it...

This pull request looks good to me to merge. @dzbaker is out of office until November 14. Can the merge wait until then?

@skliper @chillfig Merged!