nasa / cape

Computational Aerosciences Productivity & Execution
Other
22 stars 9 forks source link

Bug in Subfigure Format #10

Closed rbreslavsky closed 1 year ago

rbreslavsky commented 1 year ago

Unsure if this is a bug or intended behavior, but when indicating "Format": png for a subfigure, subfigure png files are created in addition to (not instead of) pdf files.

The resultant report is made of vector images rather than raster images.

nasa-ddalle commented 1 year ago

Altered this behavior in commit 67ecf616.

Now, if you use "Format": "png" (or "Format": "jpg"), it should just create one file and include the rasterized fig in the PDF. This was originally intended behavior with the mindset that "vector images are always better" alongside "users might want a rasterized image to use in other formats (e.g. HTML)". There's still a check for the case where you put "Format": "svg", which LaTeX can't handle (at least not normally.... that could probably be done, too), in which case CAPE spits out an .svg and .pdf to use in the report still. But now it'll just assume if you give it anything else, you really meant it, and don't create the PDF as an alternate.