search

nasa / cape

Computational Aerosciences Productivity & Execution
Other
21 stars 9 forks source link

CAPE resubmits case even when cases has failed with nan*.dat #23

Closed khalilsb closed 10 months ago

khalilsb commented 1 year ago

When running fun3d cases with two phases, if the solver diverges on the 2nd phase cape will try to resubmit that case. This creates an endless loop where it will keep resubmitting until the case is manually killed. Does cape not look for nan*dat files

nasa-ddalle commented 1 year ago

pyfun looks for nan_locations*.dat, which you can see in cape/pyfun/cntl.py. If you're using the v1.1 branch, it's possible that there was a bug created during the upgrade. Is there another kind of nan*.dat file that FUN3D can create?

nasa-ddalle commented 1 year ago

I'm looking at the cape.pyfun.case source code and seeing there might have been a long-time bug. Possibly it's only doing that check during a resubmit. The case should show as ERROR for pyfun -c, right?

nasa-ddalle commented 1 year ago

Could see some improvement from https://github.com/nasa/cape/commit/b20755d215d0bc16d56895b7a9d8c61eab00330b

Actually on leave this week, so a bit of a quick fix ...

khalilsb commented 1 year ago

thanks for the quick reply! Yup i was referring to the nan_locations*dat files. correct if it does that check during a resubmit it catches it and shows ERROR. I'll give that commit a try!