nasa / cape

Computational Aerosciences Productivity & Execution
Other
21 stars 9 forks source link

monitor mass flow convergence in reports #24

Closed khalilsb closed 7 months ago

khalilsb commented 10 months ago

for pyfun can massflow rate be added as one of the variables that can be monitored for iterative convergence

nasa-ddalle commented 10 months ago

Yes! We've done precisely this in the past, so I just need to look into how that works and if there are any code updates needed.

nasa-ddalle commented 10 months ago

You might be able to make a subfigure of the usual type ("PlotCoeff") and just set the "Coefficient" to "mdot". This appears that it would work, but it might get tripped up in the cape.cfdx.report code.

Unfortunately I don't have a good test case at the ready just now, so I'm suggesting that you try it out before I can verify it.

khalilsb commented 10 months ago

that did the trick! are all variables in the *.dat available using this method?

nasa-ddalle commented 10 months ago

Many of them are, but not necessarily all... You can get the viscous/pressure breakout terms like "C_M_zp", which gets renamed "CLNp", and you can get the lift and drag coefficients as "CL" or "CD" if available.

I think I'll take it as a feature request to add any other column that's not in my list by just replacing spaces with _. The code in cape.pyfun.dataBook that deals with this looks amazingly easy to improve.

khalilsb commented 10 months ago

thanks this is very helpful! I had asked a question previously regarding having "CL" and "CD" in databooks for creating carpet plots, will this work for other types of Subfigures such as "SweepCoeff"?