CMR-10147: Removing query parameters from self url when generating Child links

nasa / cmr-stac

Other

55 stars 21 forks source link

CMR-10147: Removing query parameters from self url when generating Child links #362

Closed william-valencia closed 1 month ago

william-valencia commented 1 month ago

The child links may contain query parameters from a get request. Need to remove these parameters when generating links in CMR-STAC

Before

After

codecov-commenter commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.34%. Comparing base (57e86a3) to head (9e01d02).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #362 +/- ## ========================================== + Coverage 88.33% 88.34% +0.01% ========================================== Files 24 24 Lines 1166 1167 +1 Branches 258 258 ========================================== + Hits 1030 1031 +1 Misses 136 136 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

macrouch commented 1 month ago

I think this PR has the wrong title. "Self" links were not modified, only "child" links, right? I was confused by this until I referenced the ticket and saw what was going on.

Need to make sure to update the PR title, and when Squash and Merging the PR make sure the correct message is recorded in the git history

william-valencia commented 1 month ago

I think this PR has the wrong title. "Self" links were not modified, only "child" links, right? I was confused by this until I referenced the ticket and saw what was going on.

Need to make sure to update the PR title, and when Squash and Merging the PR make sure the correct message is recorded in the git history

Updated the title.