gulpfile.js makes assumptions about where assets will be

nasa / cumulus-dashboard

Cumulus API Dashboard

Other

62 stars 28 forks source link

gulpfile.js makes assumptions about where assets will be #429

Closed marchuffnagle closed 6 years ago

marchuffnagle commented 7 years ago

The LPDAAC UAT deployment is failing to show graphics. The graphicsPath is being properly set in app/scripts/config/lpdaac-uat.js:

graphicsPath: '/graphics/',

gulpfile.js is using its own logic to determine where assets are. Those two need to be reconciled.

var assetsPath = process.env.DS_ENV === 'development' ? '/graphics' : '/dashboard/graphics';

scisco commented 7 years ago

@yjpa7145 i think there is a way to configure this with env variables.

@dereklieu do you have any insights here?

dereklieu commented 7 years ago

Yeah, this would be fixed by #420.

We just need to move all our config variables to a root level file, preferably yaml. Gulp should read that yaml file and make it available both to the scss task as well as the 'business' javascript code.

sethvincent commented 6 years ago

moved to jira at https://bugs.earthdata.nasa.gov/browse/CUMULUS-120