Closed etcart closed 3 months ago
one last comment, adding here for posterity I don’t know if it’s necessary immediately, but I think maybe with the next change/improvement. I see you have that last test that tests uploadDBGranules uploads a pile of entries, but you don’t check how many are actually added. Also, there’s no like “end to end” test that invokes the script/main method with a set of arguments and ensures that a certain number of collections, granules, executions, files are all added to the DB. Again, I think the tests we have now are fine since this isn’t a user facing thing. But as we add to it I think that sort of test would be helpful to have as it gets closer to something we’ll use quite a bit for setting up our testing env(s)
Summary: Summary of changes
Addresses CUMULUS-3742 record generation script
Changes
PR Checklist