Excludes aws-sdk v3 from webpack packages

nasa / cumulus

Cumulus Framework + Cumulus API

Other

248 stars 103 forks source link

Excludes aws-sdk v3 from webpack packages #3689

Closed paulpilone closed 6 days ago

paulpilone commented 3 weeks ago

Summary: Summary of changes

Excludes @aws-sdk v3 as part of the webpack packaging since we're now requiring Node v20 and don't want to include all of the SDK packages with our code.

I did this by running through the opposite PR (removal of v2): https://github.com/nasa/cumulus/pull/3618

This change is necessary because after attempting to publish v18.3.0 some of the packages were too large to publish to npm.

Changes

Excludes @aws-sdk v3 from lambda packages.

PR Checklist

[x] Update CHANGELOG
[ ] Unit tests
[ ] Ad-hoc testing - Deploy changes and test manually
[ ] Integration tests

paulpilone commented 3 weeks ago

I tested that this regex works by running npm run package before and after the change and comparing the zip sizes. e.g. in the tasks/sync-granule lambda before excluding v3:

8230652 Jun 17 09:58 lambda.zip

and then after:

4704904 Jun 17 10:15 lambda.zip

paulpilone commented 1 week ago

This is now passing CI with the updates to the async_operations and cumulus-ecs-task docker images: https://ci.earthdata.nasa.gov/browse/CUM-CBA3964-7

Related cumulus-ecs-task PR: https://github.com/nasa/cumulus-ecs-task/pull/66