search

nasa / dorado-scheduling

Dorado observation planning and scheduling simulations
Other
23 stars 8 forks source link

Call KNe light curves from gwemlightcurves #37

Closed mcoughlin closed 3 years ago

mcoughlin commented 3 years ago

Can use KNe function from gwemlightcurves to produce lightcurves.

Fixes #33 .

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@1eb60ed). Click here to learn what that means. The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   21.45%           
=========================================
  Files             ?       25           
  Lines             ?     1622           
  Branches          ?        0           
=========================================
  Hits              ?      348           
  Misses            ?     1274           
  Partials          ?        0
Impacted Files Coverage Δ
dorado/scheduling/metrics/kne.py 18.88% <50.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1eb60ed...127f457. Read the comment docs.

mcoughlin commented 3 years ago

Unit tests pass. Merging.