search

nasa / dorado-scheduling

Dorado observation planning and scheduling simulations. Replaced by https://github.com/m4opt/m4opt
Other
23 stars 8 forks source link

Prepare integration of main.py and survey.py #44

Closed mcoughlin closed 3 years ago

mcoughlin commented 3 years ago

Integration of main.py and survey.py.

lpsinger commented 3 years ago

Please rebase. Sorry, I made some changes to main.py last night!

codecov[bot] commented 3 years ago

Codecov Report

Merging #44 (04013d4) into main (d3d3ef9) will increase coverage by 1.25%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   25.46%   26.71%   +1.25%     
==========================================
  Files          29       28       -1     
  Lines        1453     1355      -98     
==========================================
- Hits          370      362       -8     
+ Misses       1083      993      -90
Impacted Files Coverage Δ
dorado/scheduling/scripts/main.py 9.64% <0.00%> (-0.36%) :arrow_down:
dorado/scheduling/scripts/simsurvey.py 9.13% <0.00%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3d3ef9...04013d4. Read the comment docs.

lpsinger commented 3 years ago

Did you try this out with both the --skygrid-method and --skygrid-file options?

mcoughlin commented 3 years ago

Yes both seem to run alright.

lpsinger commented 3 years ago

I approved it, but there are still some merge conflicts.

mcoughlin commented 3 years ago

I see: This branch has no conflicts with the base branch Merging can be performed automatically. ? or are there issues?

lpsinger commented 3 years ago

This branch has no conflicts with the base branch

Screen Shot 2021-04-27 at 11 49 58

lpsinger commented 3 years ago

Thank you, @mcoughlin! Let's keep looking for opportunities to consolidate functionality.