search

nasa / dorado-scheduling

Dorado observation planning and scheduling simulations
Other
23 stars 8 forks source link

Remove SurveyModel class #55

Closed mcoughlin closed 3 years ago

mcoughlin commented 3 years ago

Fixes #54.

codecov[bot] commented 3 years ago

Codecov Report

Merging #55 (b911a1b) into main (30310f3) will increase coverage by 0.12%. The diff coverage is 5.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   26.92%   27.05%   +0.12%     
==========================================
  Files          28       27       -1     
  Lines        1348     1327      -21     
==========================================
- Hits          363      359       -4     
+ Misses        985      968      -17
Impacted Files Coverage Δ
dorado/scheduling/scripts/animate_survey.py 5.59% <0.00%> (+0.29%) :arrow_up:
dorado/scheduling/scripts/survey_slicer.py 4.34% <0.00%> (+0.07%) :arrow_up:
dorado/scheduling/scripts/metrics.py 9.09% <5.55%> (+1.24%) :arrow_up:
dorado/scheduling/scripts/simsurvey.py 9.40% <8.19%> (+0.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 30310f3...b911a1b. Read the comment docs.

mcoughlin commented 3 years ago

Unit tests pass. Merging.

lpsinger commented 3 years ago

Very nice. Test coverage is slowly climbing up as we consolidate duplicate code.