search

nasa / dorado-scheduling

Dorado observation planning and scheduling simulations
Other
23 stars 8 forks source link

Fill gaps in sinusoidal tiling near poles #62

Closed lpsinger closed 3 years ago

lpsinger commented 3 years ago

Instead of calculating the number of tiles in a given ring from its central declination, use the declination of the edge of the ring that is closest to the equator.

This dramatically improves tiling efficiency near the poles.

Here is an example from https://dorado-scheduling.readthedocs.io/en/latest/examples/plot_skygrid.html.

Before After
sphx_glr_plot_skygrid_001 sphx_glr_plot_skygrid_001-2
sphx_glr_plot_skygrid_003 sphx_glr_plot_skygrid_003-2
codecov[bot] commented 3 years ago

Codecov Report

Merging #62 (137a4f3) into main (12ad3ea) will increase coverage by 0.10%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
+ Coverage   31.44%   31.54%   +0.10%     
==========================================
  Files          28       28              
  Lines        1342     1344       +2     
==========================================
+ Hits          422      424       +2     
  Misses        920      920
Impacted Files Coverage Δ
dorado/scheduling/skygrid/_sinusoidal.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12ad3ea...137a4f3. Read the comment docs.