nasa / dorado-scheduling

Dorado observation planning and scheduling simulations
Other
22 stars 8 forks source link

Which versions of ligo.skymap and python-ligo-lw should be used? #85

Closed DanielWarshofsky closed 1 year ago

DanielWarshofsky commented 1 year ago

When trying to import from dorado.scheduling import skygrid I get the error ImportError: cannot import name 'IDTypes' from 'ligo.lw.types'. I installed the package using pip install git+https://github.com/nasa/dorado-scheduling as recommended on the documentation page. I've looked at ligo.lw.types and it looks like IDTypes was removed from the file during v1.8. Additionally the ligo.skymap package updated in v0.61 to account for this. When using pip install git+https://github.com/nasa/dorado-scheduling I get v 0.52 for skymap but v1.83 for python-ligo-lw. These are incompatible versions. Which versions should I use?

mcoughlin commented 1 year ago

@DanielWarshofsky Does the executable run anyways? The tiling doesn't depend on most of these.

lpsinger commented 1 year ago

I haven't updated this package in a while. I'll take a look at cleaning up the dependencies shortly.

DanielWarshofsky commented 1 year ago

@mcoughlin Running the dorado-scheduling-skygrid executable produces the same error.

mcoughlin commented 1 year ago

And if you temporarily pip install ligo.skymap 0.61 or higher?

DanielWarshofsky commented 1 year ago

Updating ligo-skymap to 0.6.1 lets the executable run but gives a warning from pip ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts. dorado-scheduling 0.1.0 requires ligo.skymap<0.6.0,>=0.5.2, but you have ligo-skymap 0.6.1 which is incompatible. Down grading python-ligo-lw to before v1.8 also works but Im unsure what side effects there might be between these versions.

lpsinger commented 1 year ago

What if you use poetry install? The locked dependency versions should still work.

lpsinger commented 1 year ago

Please try again now.

DanielWarshofsky commented 1 year ago

reinstalled via pip install git+https://github.com/nasa/dorado-scheduling and It works! Thanks!