nasa / dorado-scheduling

Dorado observation planning and scheduling simulations
Other
22 stars 8 forks source link

NotImplementedError related to Orbit units when calling the scheduler with mission=uvex #94

Closed criswellalexander closed 4 months ago

criswellalexander commented 4 months ago

Calling the scheduler with the following command:

dorado-scheduling "${SKYMAP_DIR}/${num}.fits" -o "${SCHED_DIR}/${num}.ecsv" -j --mission=uvex --exptime="${texp} ks" --duration="${DURATION}" --roll-step='360 deg' --skygrid-method=sinusoidal --skygrid-step='10 deg2' --nside=128 --delay='10 yr'

where the bash variables for the fits file/ecsv file are correct absolute paths, $texp ranges from 0.5 to 10.8, and $DURATION is "3 hr",

yields a NotImplementedError:

Traceback (most recent call last): File "/home/vuk/crisw015/.conda/envs/uvex-followup-env/bin/dorado-scheduling", line 8, in sys.exit(main()) ^^^^^^ File "/home/vuk/crisw015/.conda/envs/uvex-followup-env/lib/python3.11/site-packages/dorado/scheduling/scripts/main.py", line 128, in main with u.add_enabled_equivalencies(equivalencies.orbital(mission.orbit)): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/vuk/crisw015/.conda/envs/uvex-followup-env/lib/python3.11/site-packages/dorado/scheduling/units/equivalencies.py", line 14, in orbital return Equivalency([(_orbit, orbit.period.unit, ^^^^^^^^^^^^ File "/home/vuk/crisw015/.conda/envs/uvex-followup-env/lib/python3.11/site-packages/dorado/scheduling/orbit/base.py", line 19, in period raise NotImplementedError NotImplementedError

lpsinger commented 4 months ago

Would you please attach the example sky map that you are using and provide a command line that does not contain any variables, so that I can try to reproduce this?

criswellalexander commented 4 months ago

For sure, see the fits file in the attached .zip archive. A sample command is below, although as far as I can tell the same error is produced regardless of what exposure time/skymap I've used.

dorado-scheduling 378.fits -o test.ecsv -j --mission=uvex --exptime='1.3 ks' --duration='3 hr' --roll-step='360 deg' --skygrid-method=sinusoidal --skygrid-step='10 deg2' --nside=128 --delay='10 yr'

378.zip

lpsinger commented 4 months ago

Confirmed. I'm working on it. Expect a fix later today.