nasa / earthdata-download

Download your Earth science data with only one click
https://nasa.github.io/earthdata-download/
Other
22 stars 6 forks source link

EDD-10: Send user to EDL to accept a EULA when necessary #14

Closed macrouch closed 1 year ago

macrouch commented 1 year ago

Overview

What is the feature?

When EDD detects a EULA needs to be accepted, it will open the user's browser to EDL with a redirect_uri provided by the initiating application (EDSC). After that application opens EDD again, the download will try again.

This PR also adds some more useful information as errors when a file fails to download.

What areas of the application does this impact?

Downloading files behind a EULA

Testing

Reproduction steps

Initiate a download from EDSC for files behind a EULA, with a user that has not accepted the EULA. After accepting the EULA EDL will redirect to EDSC, which will open EDD and continue downloading files

Checklist

macrouch commented 1 year ago

Add documentation for eulaCallback deep link

codecov-commenter commented 1 year ago

Codecov Report

Merging #14 (115cad7) into main (52437ad) will increase coverage by 0.95%. The diff coverage is 89.28%.

@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
+ Coverage   74.62%   75.57%   +0.95%     
==========================================
  Files          67       70       +3     
  Lines        1202     1298      +96     
  Branches      282      300      +18     
==========================================
+ Hits          897      981      +84     
- Misses        305      317      +12     
Files Changed Coverage Δ
src/app/constants/downloadStates.js 100.00% <ø> (ø)
src/app/pages/Downloads/Downloads.jsx 40.97% <0.00%> (-0.58%) :arrow_down:
src/main/eventHandlers/restartDownload.ts 100.00% <ø> (ø)
src/main/eventHandlers/retryErroredDownloadItem.ts 100.00% <ø> (ø)
src/main/main.ts 0.00% <0.00%> (ø)
src/main/preload.ts 0.00% <0.00%> (ø)
src/main/utils/setupEventListeners.ts 0.00% <0.00%> (ø)
src/app/components/DownloadItem/DownloadItem.jsx 90.00% <83.33%> (-1.53%) :arrow_down:
src/main/utils/verifyDownload.ts 96.15% <96.15%> (ø)
src/app/constants/humanizedDownloadStates.js 100.00% <100.00%> (ø)
... and 11 more