Closed eudoroolivares2016 closed 1 year ago
Merging #3 (9349b03) into main (821d9d3) will increase coverage by
1.10%
. The diff coverage is87.34%
.
@@ Coverage Diff @@
## main #3 +/- ##
==========================================
+ Coverage 73.69% 74.79% +1.10%
==========================================
Files 43 45 +2
Lines 802 865 +63
Branches 201 210 +9
==========================================
+ Hits 591 647 +56
- Misses 211 218 +7
Impacted Files | Coverage Δ | |
---|---|---|
src/app/components/Dialog/Dialog.jsx | 100.00% <ø> (ø) |
|
src/app/pages/Downloads/Downloads.jsx | 42.60% <ø> (-0.50%) |
:arrow_down: |
src/main/main.ts | 0.00% <0.00%> (ø) |
|
src/main/preload.ts | 0.00% <0.00%> (ø) |
|
src/main/utils/initializeDownload.ts | 0.00% <ø> (ø) |
|
src/app/dialogs/Settings/Settings.jsx | 94.44% <94.44%> (ø) |
|
src/app/components/Input/Input.jsx | 100.00% <100.00%> (ø) |
|
src/app/components/Layout/Layout.jsx | 77.77% <100.00%> (-0.80%) |
:arrow_down: |
src/main/eventHandlers/getPreferenceFieldValue.ts | 100.00% <100.00%> (ø) |
|
src/main/eventHandlers/setPreferenceFieldValue.ts | 100.00% <100.00%> (ø) |
|
... and 1 more |
Overview
What is the feature?
Adds Settings dialog modal to be able to change the concurrent downloads and the default download location
What is the Solution?
Created a settings dialog which is opened from the top right settings button and can similarly be closed
What areas of the application does this impact?
The Settings page
Testing
Open your preferences.json file that is located in /Users/eaolivar/Library/Application Support/earthdata-download/preferences.json
Reproduction steps
Open the earthdata download application open the settings from the top right button set the values that are allowed. Ensure that you can close the modal
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Currently:
Checklist
version
field in package.json and rannpm install