nasa / earthdata-download

Download your Earth science data with only one click
https://nasa.github.io/earthdata-download/
Other
22 stars 6 forks source link

EDD-49 adds clientId to metrics logger #33

Closed daniel-zamora closed 11 months ago

daniel-zamora commented 11 months ago

Overview

What is the feature?

Adds clientId to metricsLogger logging where appropriate.

What is the Solution?

Added a column to downloads in the database for clientId, so when we go to log a downloadId we will have a clientId as well.

What areas of the application does this impact?

sqllite migration pause downloads resume downloads finish download cancel downloads initiate download send to eula send to login opening deeplinks

Testing

Reproduction steps

-dev metricsLogger sends to uat edsc aws cloudwatch

Verify the metrics logger log statements for the following also log client id: pausing downloads resuming downloads finish download canceling downloads initiateting download download that requires eula download that requires login

Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

Checklist

codecov[bot] commented 11 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (694690a) 94.34% compared to head (58d5832) 94.35%.

:exclamation: Current head 58d5832 differs from pull request most recent head b879f24. Consider uploading reports for the commit b879f24 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #33 +/- ## ======================================= Coverage 94.34% 94.35% ======================================= Files 114 114 Lines 2283 2285 +2 Branches 464 464 ======================================= + Hits 2154 2156 +2 Misses 129 129 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.