Closed dpesall closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94.84%. Comparing base (
abf1d61
) to head (1093fd2
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Was this tested to ensure that it handles the use case of a change to the code signing cert?
Was this tested to ensure that it handles the use case of a change to the code signing cert?
At the moment it catches any generic failure that happens and from what I learned digging into the Electron Auto-Updater, a change in code certificate will trigger an error that this code should catch. I wasn't able to test it since we don't have the certs yet, but if you know of a way to test that I can verify that.
These two references implied to me that a code-signing error would throw an error that will be caught by the current code:
https://github.com/electron-userland/electron-builder/issues/4276
Overview
What is the feature?
When an auto update error occurs the user is notified and given the ability to manually download the latest version.
What is the Solution?
A toast is generated on an auto-update failure which links the user to the latest EDD download to manually download the latest update.
What areas of the application does this impact?
Testing
Reproduction steps
Attachments
Checklist
version
field in package.json and rannpm install