nasa / earthdata-download

Download your Earth science data with only one click
https://nasa.github.io/earthdata-download/
Other
22 stars 6 forks source link

EDD-53: Adding handling of auto-update failures #36

Closed dpesall closed 8 months ago

dpesall commented 8 months ago

Overview

What is the feature?

When an auto update error occurs the user is notified and given the ability to manually download the latest version.

What is the Solution?

A toast is generated on an auto-update failure which links the user to the latest EDD download to manually download the latest update.

What areas of the application does this impact?

Testing

Reproduction steps

  1. Download an older version of EDD
  2. Turn off internet connection
  3. Open EDD, and verify that auto-update fails and prompts the user to manually download the update

Attachments

Screenshot 2024-03-07 at 3 11 00 PM

Checklist

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.84%. Comparing base (abf1d61) to head (1093fd2).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #36 +/- ## ========================================== + Coverage 94.83% 94.84% +0.01% ========================================== Files 114 114 Lines 2322 2330 +8 Branches 471 472 +1 ========================================== + Hits 2202 2210 +8 Misses 120 120 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

macrouch commented 8 months ago

Was this tested to ensure that it handles the use case of a change to the code signing cert?

dpesall commented 8 months ago

Was this tested to ensure that it handles the use case of a change to the code signing cert?

At the moment it catches any generic failure that happens and from what I learned digging into the Electron Auto-Updater, a change in code certificate will trigger an error that this code should catch. I wasn't able to test it since we don't have the certs yet, but if you know of a way to test that I can verify that.

These two references implied to me that a code-signing error would throw an error that will be caught by the current code:

https://github.com/electron-userland/electron-builder/issues/4276

https://stackoverflow.com/questions/77209225/electron-automatic-updates-fail-code-signing-issues-on-windows