nasa / earthdata-search

Earthdata Search is a web application developed by NASA EOSDIS to enable data discovery, search, comparison, visualization, and access across EOSDIS' Earth Science data holdings.
https://search.earthdata.nasa.gov
Other
743 stars 221 forks source link

EDSC-4051: Fix Swodlr issues convert AccessMethod into functional component #1770

Closed Bccorb closed 1 month ago

Bccorb commented 2 months ago

Overview

What is the feature?

What is the Solution?

Covered in the feature descriptions.

What areas of the application does this impact?

My Project page and accessMethod manipulation

Testing

Reproduction steps

  1. Search the Collection referenced above
  2. Select some granules (less than 10)
  3. Attempt to customize and download
  4. All should work as expected
  5. Attempt to add greater than 10 granules
  6. SWODLR should be disabled.
  7. Subtract granules until there are 10 or less again
  8. SWODLR should be re-enabled

Regression test:

Attachments

After logging in/having all granules on the collection image

Too many granules: image

Allowed granules (<10) image

Checklist

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.65653% with 11 lines in your changes missing coverage. Please review.

Project coverage is 93.22%. Comparing base (7eb68d1) to head (945a2c4). Report is 1 commits behind head on main.

Files Patch % Lines
...ic/src/js/components/AccessMethod/AccessMethod.jsx 95.25% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1770 +/- ## ========================================== + Coverage 92.93% 93.22% +0.28% ========================================== Files 747 749 +2 Lines 18256 18208 -48 Branches 4736 4686 -50 ========================================== + Hits 16966 16974 +8 + Misses 1205 1187 -18 + Partials 85 47 -38 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

macrouch commented 2 months ago

Pulling SwodlrForm out into its own component is great, and does a lot to help make the component easier to understand. To continue that effort, all of the various access method specific logic/rendering should be pulled out into their own components as well.

eudoroolivares2016 commented 2 months ago

There are some in-line styles we should make classes