nasa / earthdata-search

Earthdata Search is a web application developed by NASA EOSDIS to enable data discovery, search, comparison, visualization, and access across EOSDIS' Earth Science data holdings.

https://search.earthdata.nasa.gov

Other

743 stars 221 forks source link

EDSC-4151: Convert /path/search/granules.cy.js to Playwright #1773

Closed dpesall closed 2 months ago

dpesall commented 2 months ago

Overview

What is the feature?

Converting Granules cypress tests to playwright

What is the Solution?

Rewrite relevant cypress tests in playwright.

What areas of the application does this impact?

e2e testing

Testing

Reproduction steps

Run playwright tests in the following path: paths/search/granules/granules.spec.js
Verify that all tests pass

Checklist

[x] I have added automated tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.22%. Comparing base (ff0ab6c) to head (fc99ba0).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1773 +/- ## ========================================== + Coverage 82.40% 83.22% +0.82% ========================================== Files 700 700 Lines 17503 17503 Branches 4565 4595 +30 ========================================== + Hits 14423 14567 +144 + Misses 3027 2790 -237 - Partials 53 146 +93 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dpesall commented 2 months ago

I found a good bit of formatting inconsistencies that we should clean up but nothing major. I am a little confused how we ended up with 100k+ mocks in this PR if all we were doing is converting an already existing test. Maybe we can sync up tomorrow and you can fill me in on that.

Happy to tag up tomorrow on this. I didn't create any new mocks for this test rewrite, I only reused the ones being utilized by the cypress test file. I'll definite work out all the spacing inconsistencies in the json files. Unless they somehow got changed by moving directories, they've been like that the whole time, so I'll go through and make sure they are all conforming.

dpesall commented 2 months ago

Added newlines to the end of all the files, and changed the spacing to be consistent across all files.