nasa / earthdata-search

Earthdata Search is a web application developed by NASA EOSDIS to enable data discovery, search, comparison, visualization, and access across EOSDIS' Earth Science data holdings.

https://search.earthdata.nasa.gov

Other

743 stars 221 forks source link

EDSC-3538: Make Relevancy the default sorting option on EDSC home page #1776

Closed daniel-zamora closed 2 months ago

daniel-zamora commented 2 months ago

Overview

What is the feature?

Fixes how the deployment env var is created.

What is the Solution?

Move the env var to the correct place in the static.config.json that is created by the bamboo deployment script

What areas of the application does this impact?

Deployment modifying default sort.

Testing

Reproduction steps

Modify the env var in the bamboo deployment.
Run deployment.
Verify the default sort value changes.

Checklist

[x] I have added automated tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.31%. Comparing base (950b776) to head (f8fd388).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1776 +/- ## ========================================== - Coverage 82.31% 82.31% -0.01% ========================================== Files 697 697 Lines 17436 17436 Branches 4572 4574 +2 ========================================== - Hits 14353 14352 -1 + Misses 2925 2873 -52 - Partials 158 211 +53 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eudoroolivares2016 commented 2 months ago

This just updated it to be application. instead of environment.