nasa / earthdata-search

Earthdata Search is a web application developed by NASA EOSDIS to enable data discovery, search, comparison, visualization, and access across EOSDIS' Earth Science data holdings.
https://search.earthdata.nasa.gov
Other
743 stars 221 forks source link

EDSC-2450: Implemented Datepicker and DatepickerContainer with the expected functionality #1785

Closed bnp26 closed 2 months ago

bnp26 commented 2 months ago

Overview

What is the feature?

Changed the Datepicker/DatepickerContainer so that when closing the calendar/input (blurring), dates autocomplete depending on the datetime format that was set in the input.

What is the Solution?

Updated Datepicker, DatepickerContainer, and their tests (all associated tests that are impacted by the change)

What areas of the application does this impact?

List impacted areas.

Testing

Reproduction steps

  1. Go to localhost:8080/search
  2. Open the temporal datetime filter.
  3. Enter 1999 in the start & end inputs
  4. observe the fields autocompleting to 1999-01-01 00:00:00 & 1999-12-31 23:59:59 respectively
  5. Enter 1999-02 in start and end inputs
  6. observe the fields autocompleting to 1999-02-01 00:00:00 & 1999-02-28 23:59:59 respectively
  7. edit the start date to 1999-01-06 12:00:00 and end date to 1999-02-06 13:00:00
  8. observe the dates don't autocomplete
  9. select a date using the calendar for the start and end dates and observe they autocomplete correctly.

    Attachments

Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.

We have good coverage on tests when run locally.

Screenshot 2024-08-13 at 1 16 11 PM Screenshot 2024-08-13 at 1 16 34 PM

Checklist

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.08%. Comparing base (2f7fcd5) to head (c3b3e7a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1785 +/- ## ========================================== + Coverage 83.39% 93.08% +9.68% ========================================== Files 700 747 +47 Lines 17529 18254 +725 Branches 4568 4705 +137 ========================================== + Hits 14618 16991 +2373 + Misses 2813 1216 -1597 + Partials 98 47 -51 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

trevorlang commented 2 months ago

@bnp26 - Ive got some comments back to you. Also, this branch needs to be updated with main