nasa / earthdata-search

Earthdata Search is a web application developed by NASA EOSDIS to enable data discovery, search, comparison, visualization, and access across EOSDIS' Earth Science data holdings.
https://search.earthdata.nasa.gov
Other
743 stars 221 forks source link

EDSC-4199: Granule browse images are not appearing on EDSC (IDN Search Portal) #1806

Closed eudoroolivares2016 closed 6 days ago

eudoroolivares2016 commented 6 days ago

Overview

What is the feature?

In cases where the granules are opensearch they are not hosted on the CMR so the scaleImage lambda which attempts to fetch data from a CMR call is going to fail. Additionally the id value on the granule is actually a separate endpoint which is why we were seeing some CORS errors our node-fetch call was trying to go to the endpoint in the id

What is the Solution?

Create clause to only fetch the image using the scaleImage lambda if the granule is not an opensearch granule

What areas of the application does this impact?

Granule Search result thumbnails for opensearch granules

Testing

Reproduction steps

  1. Go to the http://localhost:8080/search/granules?portal=idn&p=C3108204134-INPE&pg[0][v]=f&pg[0][gsk]=-start_date&fdc=ESA%252FESRIN&fpj=FedEO&ac=true&tl=1719422073!3!!&lat=-8.477034055239216&long=-77.8095703125&zoom=6 endpoint and ensure that we have no console warnings and that the granule thumbnails are returning as you scroll down

  2. Ensure that for non opensearch granules we are getting back the same thumbnails for granules as we were prior to the change

Attachments

image

Checklist

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.37%. Comparing base (8114767) to head (fa924f7). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1806 +/- ## ========================================== - Coverage 93.38% 93.37% -0.02% ========================================== Files 765 765 Lines 18451 18452 +1 Branches 4761 4734 -27 ========================================== - Hits 17231 17229 -2 - Misses 1136 1175 +39 + Partials 84 48 -36 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.