macrouch commented 4 days ago

Overview

What is the feature?

When we parse the wv.json file to build our GIBS tags, we need to be processing 'granule' type layers the same way we do 'wmts' type layers.

I also made a change to validateToken to only request a single row from the database, an improvement over requesting many rows and only using the first row. We want to see if this improves performance issues we've been seeing in production.

What areas of the application does this impact?

GIBS tagging/imagery

Testing

To fully test this process we need to run the code in production, because the collection concept-ids are only found in production

Checklist

[x] I have added automated tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings

codecov[bot] commented 4 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.40%. Comparing base (cac21d6) to head (d3fc209). Report is 1 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #1809 +/- ## ======================================= Coverage 93.40% 93.40% ======================================= Files 766 766 Lines 18461 18459 -2 Branches 4752 4735 -17 ======================================= - Hits 17243 17242 -1 - Misses 1135 1169 +34 + Partials 83 48 -35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eudoroolivares2016 commented 4 days ago

We should really add something in the PR description that explains what the db retrieval optimization is doing and briefly why.

nasa / earthdata-search