search

nasa / eo-metadata-tools

eo-metadata-tools is a set of repositories for working with Earth Observation metadata. At its core are common libraries and demonstration scripts for accessing the Common Metadata Repository, to be accompanied by more specific modules and scripts to do dataset-specific queries, metadata validation, etc...
Apache License 2.0
25 stars 11 forks source link

Add pyQuARC as submodule #32

Closed xhagrg closed 3 years ago

xhagrg commented 3 years ago

A reference to a related issue ticket number

Changes added:

  1. Add gitmodules
  2. Add pyQuARC as gitmodules; https://github.com/NASA-IMPACT/pyQuARC

How to test said change:

  1. Navigate to the pyQuARC folder
  2. All the files from the recent commit in the aforementioned repository should be there.
  3. All git operations will be directed to the pyQuARC repository.
  4. Tests can be ran using pytest
amarouane-ABDELHAK commented 3 years ago

Why not pointing to pyQuARC releases instead of having it as a submodule? we can have a requirements.txt and point to a specific tag like so git+git://github.com/path/to/pyQuARC@<tag>#egg=pyQuARC That if you don't want to publish pyQuARC to pypi and refer to it as a dependency.

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e56d08c). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #32   +/-   ##
=========================================
  Coverage          ?   82.95%           
=========================================
  Files             ?        7           
  Lines             ?      522           
  Branches          ?        0           
=========================================
  Hits              ?      433           
  Misses            ?       89           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e56d08c...3f3e077. Read the comment docs.