Bugfix/cmr-7820 - fixing url builder to prevent it from failing on expected requests.

nasa / eo-metadata-tools

eo-metadata-tools is a set of repositories for working with Earth Observation metadata. At its core are common libraries and demonstration scripts for accessing the Common Metadata Repository, to be accompanied by more specific modules and scripts to do dataset-specific queries, metadata validation, etc...

Apache License 2.0

25 stars 11 forks source link

Bugfix/cmr-7820 - fixing url builder to prevent it from failing on expected requests. #49

Closed jceaser closed 2 years ago

jceaser commented 2 years ago

Ticket CMR-7820

It was possible to specify values for the env which caused the url builder function to return a bad CMR URL.

cmr/search/common, cmr/util/common.py and the related test files are the only ones related to the bug fix.

The vast majority of these file changes are pylint requested changes however to bring the code back to zero warnings.

python moved to 3.6 as this is the standard that pylint is working against.

tbs1979 commented 2 years ago

looks good

jceaser commented 2 years ago

the one comment here I will remove in my next pull request which is just behind this one.