nasa / fpp

F Prime Prime: A modeling language for F Prime
https://fprime.jpl.nasa.gov
Apache License 2.0
49 stars 31 forks source link

C++ struct writer #143

Closed tiffany1618 closed 2 years ago

tiffany1618 commented 2 years ago

Closes #137 Closes #138

Added

Changes from Python XML struct autocoder:

tiffany1618 commented 2 years ago

fpp-to-xml gives an error for empty structs, but fpp-to-cpp currently doesn't. Do we want fpp-to-cpp to also give an error?

bocchino commented 2 years ago

fpp-to-xml gives an error for empty structs, but fpp-to-cpp currently doesn't. Do we want fpp-to-cpp to also give an error?

No. Empty structs are allowed in FPP and in C++. The error in fpp-to-xml exists because the XML schema does not support them. So this is a case where we are implementing part of the FPP spec that is not implemented when going through XML.

bocchino commented 2 years ago

Also, same comment as on #144 -- please re-run all unit tests and update them as necessary.