Fixing removing the nullptr from join calls

nasa / fpp

F Prime Prime: A modeling language for F Prime

https://fprime.jpl.nasa.gov

Apache License 2.0

41 stars 31 forks source link

Fixing removing the nullptr from join calls #425

Closed LeStarch closed 1 month ago

LeStarch commented 2 months ago

Closes issue #424

bocchino commented 2 months ago

Looks good, but can we hold off on merging this until https://github.com/nasa/fprime/pull/2672 is merged into devel? Otherwise the code generated by FPP won't compile except against that PR branch, which looks like it's still in draft status.

bocchino commented 2 months ago

I'm going to make this a draft PR for now. We can make this and https://github.com/nasa/fprime/pull/2672 ready for review at the same time.

LeStarch commented 2 months ago

@bocchino I agree, this can hang out until the other is merged. Note: that one was a draft PR, but is now in-review. I was just cleaning up the CI tests before de-drafting it.