nasa / fpp

F Prime Prime: A modeling language for F Prime
https://fprime.jpl.nasa.gov
Apache License 2.0
49 stars 31 forks source link

Updated XML and GDS limitations #402 #455

Closed jwest115 closed 3 months ago

jwest115 commented 3 months ago

Removed XML and GDS limitations that are no longer relevant and/or fixed.

I removed any limitations that are related to XML to CPP since we no longer use the XML to generate CPP.

Also, for the XML limitation regarding limits for telemetry channels of array or struct types - I verified that the limits for these types are in the XML and JSON dictionary, however, the limits do not appears in the telemetry tab in the GDS. Based on #2754, this appears to be a bug in the GDS, so I think we can change this to a GDS limitation or leave it out... @bocchino let me know what you think!

Closes #402.

timcanham commented 3 months ago

We don't want to lose color-coding. That is very important for live testing.

jwest115 commented 3 months ago

@timcanham agreed - FPP includes the limit info/colors in the dictionary. My comment above was mainly referring to F´ GDS, since it looks like it does not render the appropriate colors in the channel tab. @thomas-bc created an issue for that https://github.com/nasa/fprime/issues/2754