Closed SMorettini closed 1 year ago
Can you explain the motivation for this PR a bit more?
About point 1: I thought about this change because I was using gds to communicate with a subsystem of my project that doesn't use Fprime. So I created the xml dictionary manually and I didn't put the format string. About point 2: I didn't consider that case.
If the idea is to support only the dictionary produced by fpp, then we can close this pull request directly.
I see this PR as patching an edge case. What to do when format-string == ""? In FPP the user would have to explicitly place an empty string which likey means that was intended...but that is not useful.
Outside of FPP (dictionary) it means the text was hand-edited and the format string was forgotten.
Change Description
This merge request add a
display_text
for events having arguments but not aformat_string
.Rationale
Before the arguments of an event without a
format_string
were not logged or printed everywhere. This pull request will enable the visualization of the argument also if theformat_string
is not set.An event with no
format_string
but three arguments(an integer, an enum and a float) will contain in the column Event Description of gds:[{'My_integer_arg': 123}, {'My_enum_arg': 'VALUE_OF_ENUM'}, {'My_float_arg': 12.34}]
.