search

nasa / fprime-tools

F´ Python tooling and helpers.
https://github.com/nasa/fprime
Apache License 2.0
21 stars 39 forks source link

adding default cmake settings #105

Closed LeStarch closed 2 years ago

LeStarch commented 2 years ago
Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s)
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Enables users to set the default_cmake_options settings.ini field to pass in default cmake options.

LeStarch commented 2 years ago

@kevin-f-ortega I added a fix to for the missing test case. Formatting is at the whim of our formatter.

Joshua-Anderson commented 2 years ago

Totally late and very optional feedback, but I was wondering if using YAML list instead of newlines to separate options might be a bit cleaner and simpler? I think this is generally a more common YAML practice, I've never actually seen multiline strings without quotes like this before, though it does seem to work fine!

Ex:

default_cmake_options:
    - OPTION1=ABC
    - OPTION2=123
    - OPTION3=Something

instead of:

default_cmake_options: OPTION1=ABC
    OPTION2=123
    OPTION3=Something

I figured I might bring this up before this feature goes into regular use and we have to start thinking about backwards compatibility concerns.