search

nasa / fprime-tools

F´ Python tooling and helpers.
https://github.com/nasa/fprime
Apache License 2.0
21 stars 39 forks source link

`fprime-util new` not working since v3.1.0 #109

Closed thomas-bc closed 1 year ago

thomas-bc commented 1 year ago
F´ Version fprime-tools >=3.1.0
Affected Component fprime-util new

Problem Description

fptools v3.1.0 added the pass_through argument to the runners[parsed.command] call for calling the runner (see diff). However the callback for the new runner was not updated accordingly, and is still only taking 4 arguments instead of 5 (see here)

How to Reproduce

  1. $ pip install fprime-tools==3.1.0 (or any version >=3.1.0)
  2. $ fprime-util new --component throws 
    [ERROR] template() takes 4 positional arguments but 5 were given

Comment

Has this not been caught because this command is not used with F` v3, since it's generating XML? The fix is very easy so I'll make a PR. Should help with https://github.com/fprime-community/fprime-tools/issues/37.