search

nasa / fprime-tools

F´ Python tooling and helpers.
https://github.com/nasa/fprime
Apache License 2.0
21 stars 39 forks source link

Validate for new build structure #154

Closed thomas-bc closed 1 year ago

thomas-bc commented 1 year ago
Originating Project/Creator
Affected Component
Affected Architectures(s)
Related Issue(s) https://github.com/nasa/fprime/issues/2094
Has Unit Tests (y/n)
Builds Without Errors (y/n)
Unit Tests Pass (y/n)
Documentation Included (y/n)

Change Description

Making sure we're still relevant for the new build structure introduced by https://github.com/nasa/fprime/pull/1994 Correcting "assumptions" in the code that deployment==cmake project, which mostly came down to variable names and vocabulary. I had to scrub a minor thing in new --component that would use the deployment's name as default prompt for component namespace, if the command is ran from a deployment. I thought about switching to using CWD's name, since that's usually what I've seen being used.

Testing/Review Recommendations

I tested as much as I could with projects on the old and new build structure, as well as with core fprime.

LeStarch commented 1 year ago

"I thought about switching to using CWD's name, since that's usually what I've seen being used." Yes! Do this!