search

nasa / fprime-tools

F´ Python tooling and helpers.
https://github.com/nasa/fprime
Apache License 2.0
20 stars 38 forks source link

added dash to list of invalid characters #209

Closed keck-in-space closed 2 months ago

keck-in-space commented 2 months ago
Related Issue(s) https://github.com/nasa/fprime/issues/2802
Has Unit Tests (y/n) n
Documentation Included (y/n) n

Change Description

This change just adds the - character to the list of invalid characters in the is_valid_name function.

Rationale

This fixes an issue encountered when a component name has a - in it.

Testing/Review Recommendations

Once unit tests are written for the util functions, one could add a unit test that verifies a name with the - is considered invalid.

Future Work

NA