search

nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.09k stars 1.32k forks source link

CI CppCheck/CppScan failing #1931

Closed thomas-bc closed 1 year ago

thomas-bc commented 1 year ago
F´ Version
Affected Component

Problem Description

See https://github.com/nasa/fprime/actions/runs/4390265240/jobs/7688586298. CI is failing on CppLint and CppCheck scans because the --force option of Microsoft's SARIF-Multitool converter is not available anymore. Probably an update of the convert tool.

Fix is likely going to be to simply remove the option (or use the older version of the tool?), but we should also check what it used to be doing to be sure we're not losing any functionality.

thomas-bc commented 1 year ago

@ThibFrgsGmz do you want to take a look into that or should I?

ThibFrgsGmz commented 1 year ago

@thomas-bc I'll take a look tonight. While browsing the github repo I see some people get the same issue: https://github.com/microsoft/sarif-sdk/issues/2638

ThibFrgsGmz commented 1 year ago

For the time being, we may revert to the previous version, i.e. 4.0.0, by replacing the installation commands:

https://github.com/nasa/fprime/blob/bbf049ecbd82895a0c2de3e5d126dcea55618ceb/.github/workflows/cpplint-scan.yml#L33

and

https://github.com/nasa/fprime/blob/bbf049ecbd82895a0c2de3e5d126dcea55618ceb/.github/workflows/cppcheck-scan.yml#L32 with npm i @microsoft/sarif-multitool@4.0.0

thomas-bc commented 1 year ago

Fixed - Thanks for working on this!