nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.06k stars 1.3k forks source link

Update Seqgen to support complex commanding #2157

Open thomas-bc opened 1 year ago

thomas-bc commented 1 year ago
F´ Version
Affected Component

Feature Description

Update GDS Seqgen to support complex types commanding

LeStarch commented 11 months ago

Did some initial investigation on this.

  1. This is going to be a substantial change as most of the seqgen file parser needs to be replaced
  2. The algorithm the UI uses has been ported to python here: https://github.com/LeStarch/fprime-gds/tree/update/complex-sequencing
  3. Need to deal with the time tokens:
    1. Could parse separately
    2. Could add a regex clause to support R and A time tokens
  4. Need to deal with ;
LeStarch commented 7 months ago

@Joshua-Anderson and @timcanham given the desire to improve the sequencer, is improving the old sequencing tools still valuable? Or should I shelve this issue as it will be resolved with the revitalization effort?

Joshua-Anderson commented 7 months ago

My suspicion is that the sequencer revitalization is still a ways off, and we would likely keep the current command sequencer around as an simpler option for folks who don't need the complexity of the full sequencer.

It would be a reasonable call to implement complex commanding in the current tinyseqgen compiler. That being said, I think it's probably a pretty low priority. Complex types seem to be less common in commanding than telemetry.