search

nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.03k stars 1.29k forks source link

Issue 2457 #2502

Closed LeStarch closed 6 months ago

LeStarch commented 7 months ago
Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Issue #2457

LeStarch commented 7 months ago

@bocchino this should be ready for review. It appears the PI CI is offline again...but those have been passing.

bocchino commented 7 months ago

Looks great! An improvement on many fronts. Please take a look at the comments.

LeStarch commented 7 months ago

@bocchino I think I fixed or addressed each of your comments. Let me know if there is more you'd like to see!

bocchino commented 6 months ago

I think the type names agree with what we want (FwSizeStoreType). This looks good to me!

LeStarch commented 6 months ago

CI passed, hanging on artifact-uploade. I will merge now.