search

nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.02k stars 1.3k forks source link

Force Git Clone To Select Unix Line Endings #2566

Closed LeStarch closed 6 months ago

LeStarch commented 6 months ago
F´ Version
Affected Component

Problem Description

fprime-bootstrap clones forums without specifying Unix line endings. In some cases this can cause files to checkout with Windows line endings that then breaks tools.

We should supply get with designated flags to use Unix line ending.

Context / Environment

WSL

thomas-bc commented 6 months ago

@LeStarch see core.autocrlf config here: https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration

It seems input is the config we want, but I am a little wary about setting this option for every system when really just a limited subset should need it... do you have any experience with this? Can you confirm input is what we want to set?

LeStarch commented 6 months ago

Perhaps the best approach is to add a note to the trouble shooting guide in install for WSL systems and collect more data before fixing this? If so, mark this as will not fix.

thomas-bc commented 6 months ago

Closing as wontfix, as it may introduce more issues than it will fix.