nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.05k stars 1.3k forks source link

fprime-gds: default file downlink directory can overwrite files #2657

Open timcanham opened 6 months ago

timcanham commented 6 months ago
F´ Version v3.4.3
Affected Component n/a

Feature Description

Have GDS created a time-tag directory for file downlinks.

Make the default be logs/<time tag>/fprime-downlink to match telemetry and events.

Also, make a separate argument for uplink and downlink. It makes sense to automatically separate downlinked files, but uplink may wish to be in a common store.

Rationale

The default /tmp/username (or even overridden with --file-storage-directory) directory for file downlinks can cause new instances to overwrite older files, or cause parallel instances to clobber each other.

Joshua-Anderson commented 6 months ago

Also discussed in https://github.com/nasa/fprime/issues/2658#issuecomment-2035578624