nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
10.05k stars 1.3k forks source link

Update JSON Dictionary spec #2663

Closed thomas-bc closed 5 months ago

thomas-bc commented 6 months ago
Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Rationale

Updating the spec with regards to feedback from inputting into the GDS / build system

Testing/Review Recommendations

Will be drastically easier to review with the "Display Rich Diff" option in the changed files

image
bocchino commented 6 months ago

FPP annotations must be ASCII character strings. You could replace Schrödinger with Schroedinger.

thomas-bc commented 6 months ago

Agreed, fixed!

thomas-bc commented 6 months ago

Note to self: there's an issue with the rendering of some tables in the spec on the website: https://nasa.github.io/fprime/Design/fpp-json-dict.html

This could be the solution: https://github.com/orgs/community/discussions/23945#discussioncomment-3242285

thomas-bc commented 6 months ago

nvm: very likely has to do with whitespaces https://www.reddit.com/r/github/comments/15gexlw/comment/juik4y3

Fixed

thomas-bc commented 5 months ago

This state of the JSON dictionary spec is in sync with fpp-to-dict=2.1.0a7 (https://pypi.org/project/fprime-fpp-to-dict/2.1.0a7/)