search

nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
9.95k stars 1.28k forks source link

Fixing port selection in TCP UTs #2739

Closed LeStarch closed 1 month ago

LeStarch commented 1 month ago
Related Issue(s)
Has Unit Tests (y/n)
Documentation Included (y/n)

Change Description

Fixes the TCP port selection problem for TCP UTs. This was done by:

  1. Allowing Tcp and UDP recv to use port "0" (have OS assign port).
  2. Add read-back for "0" ports.
  3. Supply read-back port to UT as the connection port
  4. Correcting port selection and readback for network byte order
LeStarch commented 1 month ago

Note: I have run the UTs multiple 100's of times each in a known-failing environment. No issues were revealed.

LeStarch commented 1 month ago

@JohanBertrand I should have fixed both issues!

JohanBertrand commented 1 month ago

All good from my side, thank you!