nasa / fprime

F´ - A flight software and embedded systems framework
https://fprime.jpl.nasa.gov
Apache License 2.0
9.95k stars 1.28k forks source link

Channel Tab is not displaying colors based on limit values #2754

Open thomas-bc opened 1 month ago

thomas-bc commented 1 month ago
F´ Version fprime-gds@devel
Affected Component

Problem Description

When specifying a limit

        telemetry Channel1: U32 high { red 3, orange 2, yellow 1 }

and the channel goes above the threshold, I would expect the row to change colors. But I haven't been able to observe that behavior

Calculating the row color is here: https://github.com/nasa/fprime-gds/blob/2c95a45d044dc26b74da1c55c1197fc4bf3b7e7d/src/fprime_gds/flask/static/js/vue-support/channel.js#L86-L107 There may be a bug here or in the handling of the limit values, or in the display somewhere.

How to Reproduce

  1. Add a limit to a channel in Ref/
  2. Build, and trigger the telemetry so that it will go beyond the limit
  3. observe color in channel tab

Expected Behavior

Channel row should take the appropriate color